[riot-notifications] [RIOT-OS/RIOT] tests: add tests to reproduce #10881 (#10908)

Gaƫtan Harter notifications at github.com
Thu Mar 28 15:16:31 CET 2019


cladmi approved this pull request.

I could run the test on `arduino-mega2560 frdm-k64f frdm-kw41z msba2 mulle nrf52dk nucleo-f103rb pba-d-01-kw2x sltb001a stm32f3discovery`.

I did not review the code in details but the implementation seems right to me, was reviewed when fixing the code and it shows the issue when reverting #10811 locally.

The test should really be merged when the issue is there otherwise people loose interest and it is harder to verify it testing. Even maybe by disabling the test at the beginning (or other mechanism) instead of not adding a good test.

Please squash.



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/10908#pullrequestreview-220047701
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190328/eca20fc0/attachment-0001.html>


More information about the notifications mailing list