[riot-notifications] [RIOT-OS/RIOT] pkg: add pkg libbase58 (#10957)

Kaspar Schleiser notifications at github.com
Thu Mar 28 20:52:23 CET 2019


kaspar030 commented on this pull request.



> +
+#include "libbase58.h"
+#include "embUnit.h"
+
+static void setUp(void)
+{
+}
+
+static void test_libbase58_01(void)
+{
+    const char source[] = "base 58 test string";
+    const char encoded[] = "K1cpEhnSEL8mbBfpp7f6z3dSZ4";
+    char target[64] = {0};
+    size_t target_len = sizeof(target);
+
+    b58enc(target, &target_len, source, sizeof(source)-1);

I've added a decoding step to the tests. For everything else, I'd suggest sticking to the libbase58 documentation.

> Also, where did your test data came from? How can I verify it?

I've added a "puts" at strategic places and then copy&pasted the string from the (at that point failing) test output... 

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/10957#discussion_r270173265
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190328/8fb710db/attachment.html>


More information about the notifications mailing list