[riot-notifications] [RIOT-OS/RIOT] cpu/stm32_common: add watchdog for stm32 (#11252)

Alexandre Abadie notifications at github.com
Fri Mar 29 12:04:29 CET 2019


aabadie requested changes on this pull request.

> If you look at the python test I make use of two fucntions to get the min and max value for the wdg timer

You could also use regex to retrieve these values. I'm not a big fan of json for this kind of semi-automated tests: since there's a shell, this means the application is supposed to be used interactively by a someone.

> Also I removed showing the actual tiem value for the wdg timer unless the DEBUG option is enabled. Should I just remove this?

I think it's fine like this: it provides an easy way to debug in case it doesn't work.

Otherwise, I still have unaddressed comments and Travis CI is reporting some issues (of different kind).



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/11252#pullrequestreview-220482247
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190329/ac6afa19/attachment.html>


More information about the notifications mailing list