[riot-notifications] [RIOT-OS/RIOT] boards/esp32: changes the approach for configurations of ADC channels in board definitions (#11289)

Gunar Schorcht notifications at github.com
Fri Mar 29 19:20:27 CET 2019


@leandrolanzieri Hm, ... `periph/adc.c` is part of module `periph` and is always compiled. For `test/periph_adc` the compilation in mrudock doesn't fail since it requires feature `periph_adc` which is not provided by `esp32-olimex-evb`. But for all other application `periph_adc` isn't required. That's why they fail in murduck with something like:
```
cpu/esp32/periph/adc.c:173:27: error: comparison of unsigned expression < 0 is always false [-Werror=type-limits]
     CHECK_PARAM_RET (line < ADC_NUMOF, -1)
```
And now I remember that this was the reason why I had the variable `adc_channel_num` in addition to the macro `ADC_NUMOF`. The check against the varaiable doesn't fail during compilation. 

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/11289#issuecomment-478100561
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190329/33831602/attachment.html>


More information about the notifications mailing list