[riot-notifications] [RIOT-OS/RIOT] cpu/sam0: add support for SAMD5x/SAME5x (#11305)

Kees Bakker notifications at github.com
Fri Mar 29 22:54:04 CET 2019


keestux commented on this pull request.



> +/**
+ * @brief Timer state memory
+ */
+static timer_isr_ctx_t config[TIMER_NUMOF];
+
+/* enable timer interrupts */
+static inline void _irq_enable(tim_t dev);
+
+
+/**
+ * @brief Setup the given timer
+ */
+int timer_init(tim_t dev, unsigned long freq, timer_cb_t cb, void *arg)
+{
+    /* at the moment, the timer can only run at 3MHz */
+    if (freq != 32768ul) {

Comment says "3MHz", but this number is 32768. Is that correct?
BTW. The value of `freq` is unused (same in saml1x).

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/11305#pullrequestreview-220772119
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190329/ab8d7248/attachment.html>


More information about the notifications mailing list