[riot-notifications] [RIOT-OS/RIOT] boards/esp32: changes the approach for configurations of ADC channels in board definitions (#11289)

Gunar Schorcht notifications at github.com
Sat Mar 30 00:59:26 CET 2019


@leandrolanzieri Commit https://github.com/RIOT-OS/RIOT/pull/11289/commits/0e50abd4c2358e814af1c10ac1b6ed7b88fd02b2 should fix the problem. Let's see what murdock says.
One comment. Even though defines for ADC and DAC are changes in commit https://github.com/RIOT-OS/RIOT/pull/11289/commits/0e50abd4c2358e814af1c10ac1b6ed7b88fd02b2, I would like to leave it in this commit because it is necessary to fixes compile problems with ADC and it will prevent merge conflicts with the DAC PR #11290. Unfortunatly, ADCs and DACs have to be handled in same file since they use the same hardware unit.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/11289#issuecomment-478183521
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190329/dbff00aa/attachment.html>


More information about the notifications mailing list