[riot-notifications] [RIOT-OS/RIOT] can stm32: add a driver for STM32 bxCAN peripheral (#6178)

Gunar Schorcht notifications at github.com
Sat Mar 30 01:47:29 CET 2019


@vincent-d 
ESP32 integrates a CAN DLL and PHY signaling sublayer controller which is compatible with the NXP SJA1000 CAN controller. The `esp_can` module implements a CAN driver as documented in [CAN device driver interface](https://riot-os.org/api/group__drivers__candev.html) for the ESP32 CAN controller which is used by [CAN Data Link Layer](https://riot-os.org/api/group__sys__can__dll.html).

You also implement the STM32 CAN interface according to [CAN device driver interface](https://riot-os.org/api/group__drivers__candev.html). But instead defining an architecture specific auto initialization function, you also define a new low level peripheral interface `periph/can` with auto initialization functionality. Great idea :smile:

The compilation error occurs since the board definition of `esp32-olimex-evb` enables feature `periph_can` why `can_params.h` is tried to be included in `sys/auto_init/can/auto_init_periph_can.c` which doesn't exist in ESP32 CAN implementation :worried:

Two options to solve the problem:

1. We change `esp32-olimex-evb` board definition as follows
    ```diff
    - FEATURES_PROVIDED += periph_can
    + FEATURES_PROVIDED += esp_can
    ```

2. We adapt `esp_can` according to your new interface.

Maybe, the easiest way for the moment might be to follow option 1 and once your PR is merged I can try to realize option 2 as separate PR.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/6178#issuecomment-478189858
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190329/b30e836d/attachment.html>


More information about the notifications mailing list