[riot-notifications] [RIOT-OS/RIOT] sam0_common: make RTC implementation common across all sam0 MCUs (#11317)

Dylan Laduranty notifications at github.com
Sun Mar 31 18:24:14 CEST 2019


dylad commented on this pull request.



>      RTC->MODE2.CTRLA.bit.ENABLE = 0;
-    while (RTC->MODE2.SYNCBUSY.bit.ENABLE);
+#else
+    RTC->MODE2.CTRL.bit.ENABLE = 0;
+#endif
+#ifdef REG_RTC_MODE2_SYNCBUSY

I would replace these `#ifdef REG_RTC_MODE2_SYNCBUSY` block by a static or static inline function here. Easier to read and more compact.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/11317#pullrequestreview-220871940
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190331/7aa992b4/attachment-0001.html>


More information about the notifications mailing list