[riot-notifications] [RIOT-OS/RIOT] dist/tools/buildsystem_sanity_check: add an export variable check (#11484)

Gaƫtan Harter notifications at github.com
Fri May 3 15:30:55 CEST 2019


cladmi commented on this pull request.



> +UNEXPORTED_VARIABLES+=('TERMPROG' 'TERMFLAGS')
+check_not_exporting_variables() {
+    local patterns=()
+    local pathspec=()
+
+    for variable in "${UNEXPORTED_VARIABLES[@]}"; do
+        patterns+=(-e "export ${variable}")
+    done
+
+    pathspec+=('*')
+
+    # Ignore `makefiles/vars.inc.mk` as it currently is the only place that
+    # should export common variables.
+    pathspec+=(':!makefiles/vars.inc.mk')
+
+    git -C "${RIOTBASE}" grep "${patterns[@]}" -- "${pathspec[@]}"

I do not want to display it at all. It was just a stupid debug line remaining.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/11484#discussion_r280774721
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190503/63084b99/attachment.html>


More information about the notifications mailing list