[riot-notifications] [RIOT-OS/RIOT] kinetis: move filtering-out periph_hwrng in cpu/kinetis (#11479)

Alexandre Abadie notifications at github.com
Mon May 6 08:36:26 CEST 2019


aabadie requested changes on this pull request.

ACK for the proposed HACK. I would just reword a bit the comments.

> @@ -1,5 +1,18 @@
 FEATURES_PROVIDED += periph_cpuid
-FEATURES_PROVIDED += periph_hwrng
+
+# HACK Do not define 'hwrng' if the board does not supports it
+# I prefer a whitelist on CPU_MODEL but the information is not available yet

This comment has too much personal taste (e.g. don't use  `I prefer`). Maybe reword with: `A whitelist on CPU_MODEL would be better but this information/variable is not available yet.`

> @@ -1,5 +1,18 @@
 FEATURES_PROVIDED += periph_cpuid
-FEATURES_PROVIDED += periph_hwrng
+
+# HACK Do not define 'hwrng' if the board does not supports it
+# I prefer a whitelist on CPU_MODEL but the information is not available yet
+# HACK the board/cpu_model currently uses the wrong hwrng register

If I understand this correctly, the wrong hwrng register is used for frdm-k64f ? Maybe make this more explicit that this HACK applies to frdm-kw64f.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/11479#pullrequestreview-233839734
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190505/3f7db371/attachment.html>


More information about the notifications mailing list