[riot-notifications] [RIOT-OS/RIOT] Makefile.features: prerequisites for moving CPU/CPU_MODEL to boards/Makefile.features (#11478)

Francisco notifications at github.com
Mon May 6 13:53:59 CEST 2019


fjmolinas commented on this pull request.

Good stepping stone towards #11477, I have a minor comment to improve variable documentation.

> @@ -8,7 +8,7 @@ export QUIET                 # The parameter to use whether to show verbose make
 export APPLICATION           # The application, set in the Makefile which is run by the user.
 export APPLICATION_MODULE    # The application module name.
 export BOARD                 # The board to compile the application for.
-export CPU                   # The CPU, set by the board's Makefile.include.
+export CPU                   # The CPU, set by the board's Makefile.features.

I like the comment specifying where CPU should be defined, it documents a little bit the build system variables. Could we do the same for CPU_MODEL?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/11478#pullrequestreview-233938166
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190506/4c2a2323/attachment.html>


More information about the notifications mailing list