[riot-notifications] [RIOT-OS/RIOT] Makefile.features: prerequisites for moving CPU/CPU_MODEL to boards/Makefile.features (#11478)

Gaƫtan Harter notifications at github.com
Mon May 6 15:20:24 CEST 2019


One argument in the direction that even if there is a better solution for the future it does not change anything right now for the `CPU` variable.

If you look at these lines:

These one checks that the cpu features are indeed parsed:

https://github.com/RIOT-OS/RIOT/blob/3f9a6410f0c2dad6d09e24f10dbf2f12cea842db/Makefile.include#L260-L265

And it is fulfilled for the first 5 boards by the following lines which hardwrite the value of `CPU`. So `CPU` is already "defined" in the `board/board_common/Makefile.features`

https://github.com/RIOT-OS/RIOT/blob/3f9a6410f0c2dad6d09e24f10dbf2f12cea842db/boards/common/nrf52/Makefile.features#L12
https://github.com/RIOT-OS/RIOT/blob/3f9a6410f0c2dad6d09e24f10dbf2f12cea842db/boards/common/nrf51/Makefile.features#L5
https://github.com/RIOT-OS/RIOT/blob/3f9a6410f0c2dad6d09e24f10dbf2f12cea842db/boards/common/arduino-due/Makefile.features#L16
https://github.com/RIOT-OS/RIOT/blob/3f9a6410f0c2dad6d09e24f10dbf2f12cea842db/boards/arduino-duemilanove/Makefile.features#L3
https://github.com/RIOT-OS/RIOT/blob/3f9a6410f0c2dad6d09e24f10dbf2f12cea842db/boards/arduino-mega2560/Makefile.features#L4


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/11478#issuecomment-489617549
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190506/caf04647/attachment.html>


More information about the notifications mailing list