[riot-notifications] [RIOT-OS/RIOT] tests/posix_semaphore: unify and increase allowed test4 margin (#11467)

Gaƫtan Harter notifications at github.com
Mon May 6 16:12:57 CEST 2019


cladmi commented on this pull request.



> @@ -236,16 +236,16 @@ void test3(void)
     sem_post(&s1);
 }
 
-#ifdef BOARD_NATIVE
-/* native can sometime take more time to respond as it is not real time */
-#define TEST4_TIMEOUT_EXCEEDED_MARGIN (300)
-#elif CPU_FAM_NRF51
-/* nrf51 based boards needs a slightly higher margin value. Using 105us makes
- test4 result more reliable. */
-#define TEST4_TIMEOUT_EXCEEDED_MARGIN (105)
-#else
-#define TEST4_TIMEOUT_EXCEEDED_MARGIN (100)
-#endif /* BOARD_NATIVE */
+/*
+ * Allowed margin for waiting too long.
+ *
+ * Waiting too short is forbidden by POSIX, but is checked elsewhere.

It is checked here, not elsewhere:

```
    if (elapsed < exp) {
        printf("first: waited only %s usec => FAILED\n", uint64_str);
    }
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/11467#pullrequestreview-234001735
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190506/27c319bf/attachment.html>


More information about the notifications mailing list