[riot-notifications] [RIOT-OS/RIOT] sys/ecc: move hamming256 module to generic ecc (#9988)

Gaƫtan Harter notifications at github.com
Mon May 6 17:19:25 CEST 2019


cladmi commented on this pull request.



> @@ -811,3 +811,7 @@ USEPKG := $(sort $(USEPKG))
 ifneq ($(OLD_USEMODULE) $(OLD_USEPKG),$(USEMODULE) $(USEPKG))
   include $(RIOTBASE)/Makefile.dep
 endif
+
+ifneq (,$(filter ecc_%,$(USEMODULE)))
+  USEMODULE += ecc
+endif

The issue with the dependency being after `OLD_USEMODULE` lines, is that if `ecc` has a dependency, they will not be resolved. So being there is wrong. There is a reason why all the others are before :D 
There are cases with `default implementation handling` that may not work with the current scheme but it is not the case here.

The issue with `core_msg` is that `Makefile.base` does not handle having `USEMODULE` with duplicates when handling `SUBMODULES` and should just be handled there by doing `sort` before listing the `.c` files.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/9988#discussion_r281231588
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190506/a2286c4b/attachment.html>


More information about the notifications mailing list