[riot-notifications] [RIOT-OS/RIOT] sys/xtimer: fix xtimer_mutex_lock_timeout corner cases (#2) (#11225)

Gaëtan Harter notifications at github.com
Mon May 6 17:55:33 CEST 2019


cladmi commented on this pull request.

I ended up seeing that code recently and I already see issues with the original one.

My first issue I see is first that removing a process from its mutex queue should maybe more be done in `mutex.c` not outside.

Also, as it is currently maybe called after spinning, it may be called outside of interrupt context, (that's an xtimer behavior) so modifying the queue without protecting the queue… I already imagine issues there. And talking to the scheduler too.

I see that you do `sched_context_switch_request` and this would only work called from an interrupt context right ?

And currently, the first commit changes a lot of things without really explaining each steps so I find it hard to review each part.



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/11225#pullrequestreview-234058021
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190506/7e16d452/attachment.html>


More information about the notifications mailing list