[riot-notifications] [RIOT-OS/RIOT] Makefile.features: add declarative FEATURES_ variables definition (#11492)
notifications at github.com
Mon May 6 18:59:56 CEST 2019
### Contribution description
Use `Makefile.features` to define all the calculated `FEATURES_` variables.
This gives a name on the resolved parsing of the BSP `FEATURES_` variables.
Then use them in `Makefile.include`/`makefiles/info.inc.mk`/makefiles/info-global.inc.mk`.
### Reviewing procedure
The review is mainly on `Makefile.features` the other changes being the consequence of the changes but they can explain what changed.
The goal is does the name makes sense and matches with what is evaluated.
The fact that the migration is correct can come in a second time.
### Testing procedure
All the supported applications should still be the same.
I added `make info-applications-supported-boards` that can be run in the base directory to compare a commit with another for listing all the boards returned by `info-boards-supported`. (I will split this one).
The output of this one should be the same with the end commit and the commit introducing it.
I will add some outputs for the `info-build` to verify the new variables in some defined cases.
### Issues/PRs references
Side work of https://github.com/RIOT-OS/RIOT/issues/9913 that added this `Makefile.features` to group the `features` handling.
Could help with https://github.com/RIOT-OS/RIOT/pull/9081 to have the definition in only one place.
* [ ] TODO: Slit the `info-applications-supported-boards`
You can view, comment on, or merge this pull request online at:
-- Commit Summary --
* makefiles/app_dirs.inc.mk: declare info-applications .PHONY
* makefiles/app_dirs.inc.mk: target to list supported applications/boards
* makefiles: Update FEATURES_OPTIONAL meaning
* Makefile.features: declare FEATURES_MISSING and make use of it
* Makefile.features: declare FEATURES_USED and make use of it
* Makefile.features: declare FEATURES_CONFLICTING and make use of it
-- File Changes --
M Makefile.dep (6)
M Makefile.features (30)
M Makefile.include (9)
M makefiles/app_dirs.inc.mk (8)
M makefiles/info-global.inc.mk (8)
M makefiles/info.inc.mk (26)
-- Patch Links --
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the notifications