[riot-notifications] [RIOT-OS/RIOT] tests/xtimer_usleep: recognize negative offset (#11493)
notifications at github.com
Tue May 7 08:54:08 CEST 2019
The RIOT community cares a lot about code quality.
Therefore, before describing what your contribution is about, we would like
you to make sure that your modifications are compliant with the RIOT
coding conventions, see https://github.com/RIOT-OS/RIOT/wiki/Coding-conventions.
### Contribution description
Put here the description of your contribution:
- describe which part(s) of RIOT is (are) involved
- if it's a bug fix, describe the bug that it solves and how it is solved
- you can also give more information to reviewers about how to test your changes
This PR modifies xtimer_usleep automated test to recognize negative offset with respect to target sleep time.
When reviewing #11044 I realized tests/xtimer_usleep wasn't passing because the python script was not recognizing negative integers as acceptable values for the timer offset, this is done now.
### Testing procedure
With frdm-kw41z or usb-kw41z (or any board witch would produce negative offset with respect to the target usleep time)
`→ make -C tests/xtimer_usleep BOARD=usb-kw41z flash test
Failed without this PR, succeeds with it.
Details steps to test your contribution:
- which test/example to compile for which board and is there a 'test' command
- how to know that it was not working/available in master
- the expected success test output
### Issues/PRs references
Examples: Fixes #1234. See also #5678. Depends on PR #9876.
Please use keywords (e.g., fixes, resolve) with the links to the issues you
resolved, this way they will be automatically closed when your pull request
is merged. See https://help.github.com/articles/closing-issues-using-keywords/.
You can view, comment on, or merge this pull request online at:
-- Commit Summary --
* tests/xtimer_usleep: recognize negative offset
-- File Changes --
M tests/xtimer_usleep/tests/01-run.py (2)
-- Patch Links --
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the notifications