[riot-notifications] [RIOT-OS/RIOT] makefiles/utils/{strings, paths}: Add function library. (#11218)

Gaƫtan Harter notifications at github.com
Wed May 8 16:46:33 CEST 2019


cladmi commented on this pull request.



>  define command_should_fail
-$1 2>/dev/null && { echo "Command '$1' should have failed but did not" >&2; $1; exit 1; } || true
+$1 2>/dev/null && { $(call fail_message,Command '$1' should have failed but did not) >&2; $1; exit 1; } || $(call ok_message,$2)

This does not work, none of the `negative` functions detect when something does not fail.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/11218#pullrequestreview-235101779
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190508/3af989cd/attachment-0001.html>


More information about the notifications mailing list