[riot-notifications] [RIOT-OS/RIOT] ili9341: Initial import of ili9341 LCD driver (#9948)

Alexandre Abadie notifications at github.com
Wed May 8 17:59:13 CEST 2019


aabadie commented on this pull request.

I tested this PR and it's still working well, except a minor issue with the RIOT logo (see my comment below).

@bergzand do you think you can update/rebase your PR so we can move forward with this ?

> @@ -0,0 +1,71 @@
+const uint16_t picture[69][128] = {

Instead of `69`, I had to use `70` with an extra empty line at the end of array to avoid having an alone green pixel at the bottom right of the logo.
I have no idea why it was there. One could think of a division by 2 issue but there is no such thing in `ili9341_map` implementation.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/9948#pullrequestreview-235144067
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190508/e6ba9879/attachment-0001.html>


More information about the notifications mailing list