[riot-notifications] [RIOT-OS/RIOT] makefiles: introduce 'LIBS' variable (#11111)

Gaëtan Harter notifications at github.com
Fri May 10 12:09:35 CEST 2019


I still question the name `LIBS` (taken from the original PR) as with this new name:

* `LIBS` are module names
* `BASELIBS` are archives. But also sometime `-lsomething` and other unrelated things that should not be there.

I would expect somehow that `LIBS` is given almost directly to the linker and not a list of special modules that will be processed.

With the naming I would be more maybe to a `ARCHIVE_MODULES` or `LIBRARY_MODULES`…

---------------


The output of the test is still "as expected":

```
BINDIR='/tmp/bin/$(BOARD)' ./compare_riot_repositories_variable_value.sh ../worktree/riot_master/ ../RIOT BASELIBS | tee output_baselibs                                                                                                                                              
/home/harter/work/git/worktree/riot_master/Makefile.dep:86: nordic_softdevice_ble: Disabling router modules: gnrc_ipv6_router gnrc_ipv6_router_default                                                                                                                                    
/home/harter/work/git/worktree/riot_master/Makefile.dep:86: nordic_softdevice_ble: Disabling router modules: gnrc_ipv6_router gnrc_ipv6_router_default                                                                                                                                    
/home/harter/work/git/RIOT/Makefile.dep:86: nordic_softdevice_ble: Disabling router modules: gnrc_ipv6_router gnrc_ipv6_router_default                                                                                                                                                    
/home/harter/work/git/worktree/riot_master/Makefile.dep:86: nordic_softdevice_ble: Disabling router modules: gnrc_ipv6_router_default gnrc_rpl auto_init_gnrc_rpl netstats_rpl                                                                                                            
/home/harter/work/git/worktree/riot_master/Makefile.dep:86: nordic_softdevice_ble: Disabling router modules: gnrc_ipv6_router_default gnrc_rpl auto_init_gnrc_rpl netstats_rpl                                                                                                            
/home/harter/work/git/RIOT/Makefile.dep:86: nordic_softdevice_ble: Disabling router modules: gnrc_ipv6_router_default gnrc_rpl auto_init_gnrc_rpl netstats_rpl                                                                                                                            
/home/harter/work/git/worktree/riot_master/Makefile.dep:86: nordic_softdevice_ble: Disabling router modules: gnrc_ipv6_router_default gnrc_rpl                                                                                                                                            
/home/harter/work/git/worktree/riot_master/Makefile.dep:86: nordic_softdevice_ble: Disabling router modules: gnrc_ipv6_router_default gnrc_rpl                                                                                                                                            
/home/harter/work/git/RIOT/Makefile.dep:86: nordic_softdevice_ble: Disabling router modules: gnrc_ipv6_router_default gnrc_rpl                                                                                                                                                            
/home/harter/work/git/worktree/riot_master/Makefile.dep:86: nordic_softdevice_ble: Disabling router modules: gnrc_ipv6_router_default gnrc_rpl auto_init_gnrc_rpl                                                                                                                         
/home/harter/work/git/worktree/riot_master/Makefile.dep:86: nordic_softdevice_ble: Disabling router modules: gnrc_ipv6_router_default gnrc_rpl auto_init_gnrc_rpl                                                                                                                         
/home/harter/work/git/RIOT/Makefile.dep:86: nordic_softdevice_ble: Disabling router modules: gnrc_ipv6_router_default gnrc_rpl auto_init_gnrc_rpl                                                                                                                                         
/home/harter/work/git/worktree/riot_master/Makefile.dep:86: nordic_softdevice_ble: Disabling router modules: gnrc_ipv6_router_default                                                                                                                                                     
/home/harter/work/git/worktree/riot_master/Makefile.dep:86: nordic_softdevice_ble: Disabling router modules: gnrc_ipv6_router_default                                                                                                                                                     
/home/harter/work/git/RIOT/Makefile.dep:86: nordic_softdevice_ble: Disabling router modules: gnrc_ipv6_router_default                                                                                                                                                                     
/bin/sh: 1: arithmetic expression: expecting primary: " + "                                                                                                                                                                                                                               
/bin/sh: 1: arithmetic expression: expecting primary: " + "                                                                                                                                                                                                                               
/bin/sh: 1: arithmetic expression: expecting primary: " + "                                                                                                                                                                                                                               
/bin/sh: 1: arithmetic expression: expecting primary: " + "                                                                                                                                                                                                                               
/bin/sh: 1: arithmetic expression: expecting primary: " + "                                                                                                                                                                                                                               
/bin/sh: 1: arithmetic expression: expecting primary: " + "                                                                                                                                                                                                                               
/bin/sh: 1: arithmetic expression: expecting primary: " + "                                                                                                                                                                                                                               
/bin/sh: 1: arithmetic expression: expecting primary: " + "                                                                                                                                                                                                                               
/bin/sh: 1: arithmetic expression: expecting primary: " + "                                                                                                                                                                                                                               
/bin/sh: 1: arithmetic expression: expecting primary: " + "                                                                                                                                                                                                                               
/bin/sh: 1: arithmetic expression: expecting primary: " + "                                                                                                                                                                                                                               
/bin/sh: 1: arithmetic expression: expecting primary: " + "                                                                                                                                                                                                                               
/bin/sh: 1: arithmetic expression: expecting primary: " + "                                                                                                                                                                                                                               
/bin/sh: 1: arithmetic expression: expecting primary: " + "                                                                                                                                                                                                                               
/bin/sh: 1: arithmetic expression: expecting primary: " + "                                                                                                                                                                                                                               
/bin/sh: 1: arithmetic expression: expecting primary: " + "                                                                                                                                                                                                                               
/bin/sh: 1: arithmetic expression: expecting primary: " + "                                                                                                                                                                                                                               
/bin/sh: 1: arithmetic expression: expecting primary: " + "        
```                                                                                                                                                                                                                       

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/11111#issuecomment-491236506
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190510/26e3a28e/attachment-0001.html>


More information about the notifications mailing list