[riot-notifications] [RIOT-OS/RIOT] makefiles/blobs: Add rules for binary blob embedding. (#11497)

Kaspar Schleiser notifications at github.com
Fri May 10 12:17:43 CEST 2019


kaspar030 requested changes on this pull request.

I agree that we need proper blob handling, and I do see that using xxd is difficult mostly because it is part of vim and not generally available. If it would, the sed magic would be acceptable.

I don't like having the functionality implemented using Makefile functions. IMO it would make much more sense to have this as a tool that is just called from make.

I don't buy the "array is bad". Having blobs declared within a header as embedded binary might not be the most efficient cycle wise, but when it comes to handling, it is *much* simpler. No need for handling *two* files (generated header and generated .o, the latter having two creation steps), arch specific stuff whatsoever, anything. For 99% of the uses, specifying a variable (base)name and whether it should be const or not is sufficient. For 1% it might make sense to be able to specify the target section and change the data type.



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/11497#pullrequestreview-236030283
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190510/bae77f6c/attachment.html>


More information about the notifications mailing list