[riot-notifications] [RIOT-OS/RIOT] cortexm_common: add .noinit section (#11521)

Juan I Carrano notifications at github.com
Tue May 14 11:45:16 CEST 2019


jcarrano requested changes on this pull request.

It is OK. Just a tiny nitpick: put the ALIGN and the end symbol inside the section to have it consistent with the other definitions. Squash and I merge.

> @@ -127,6 +127,17 @@ SECTIONS
         _erelocate = .;
     } > ram AT> rom
 
+    /*
+     * collect all uninitialized sections that go into RAM
+     */
+    .noinit (NOLOAD) :
+    {
+        __noinit_start = .;
+        *(.noinit)

```suggestion
        *(.noinit)
        . = ALIGN(4);
        __noinit_end = .;
```

> @@ -127,6 +127,17 @@ SECTIONS
         _erelocate = .;
     } > ram AT> rom
 
+    /*
+     * collect all uninitialized sections that go into RAM
+     */
+    .noinit (NOLOAD) :
+    {
+        __noinit_start = .;
+        *(.noinit)
+    }  > ram
+    . = ALIGN(4);

```suggestion
```

> @@ -127,6 +127,17 @@ SECTIONS
         _erelocate = .;
     } > ram AT> rom
 
+    /*
+     * collect all uninitialized sections that go into RAM
+     */
+    .noinit (NOLOAD) :
+    {
+        __noinit_start = .;
+        *(.noinit)
+    }  > ram
+    . = ALIGN(4);
+    __noinit_end = .;

```suggestion
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/11521#pullrequestreview-237134864
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190514/87265384/attachment.html>


More information about the notifications mailing list