[riot-notifications] [RIOT-OS/RIOT] API change, uart input not working anymore on previously working setups (#11525)

Kaspar Schleiser notifications at github.com
Tue May 14 14:00:36 CEST 2019


> This is an API change and was review without putting the label and merged without respecting the 2 ACKs for it.

This was not an API change. getchar works as expected (from ```man 3 getchar```:

```
 fgetc(), getc() and getchar() return the character read as an unsigned char cast to an int or EOF on end of file or error.
```

I agree that making previously working code not work anymore sucks, though.

The options for fixing are:

1. make uart_stdio_rx optional but default
2. add the dependency to applications that need it.
3. make all stdin reads panic() if support is not enabled
4. other ideas?

Unfortunately adding "uart_stdio_rx" doesn't cut it for e.g., native. There needs to be a level of pseudo modules, e.g., "stdio_rx (or just stdin)" which depends on "uart_stdio_rx" iff "uart_stdio" is selected... 

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/issues/11525#issuecomment-492207741
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190514/1c344e3b/attachment.html>


More information about the notifications mailing list