[riot-notifications] [RIOT-OS/RIOT] API change, uart input not working anymore on previously working setups (#11525)

Kaspar Schleiser notifications at github.com
Tue May 14 16:46:20 CEST 2019


(seems like github ate my mail reply, so here's it copy&pasted:)


> It is a RIOT code base API change. If this is not something we describe
> as an API change, please let me know.

This is a *configuration* change. *nothing* of the getchar API has been
changed. This is more like we decided that unless otherwise requested,
we do "close(STDIO_FILENO);" at program start.

That might have been a mistake, but this was technically *not an API
change*.

> To prevent this, I think that we should move in a direction that
> contributor /should/ put more information in the first place, and
> reviewer /should/ ask for more information when there is not enough.
> Even if both understand together the issue, another reader, now or in
> the future, may find this completely obscure.

I understand your frustration that something you expected working
suddenly broke. I'm sorry that happened.

Let's move on and fix it.

> The other solution is to now revert this and handle it with more time
> and mark it with an API change warning if needed.

Reverting makes no sense, there is a *strong* use case for disabling
uart rx. Changing to the previous default (by selecting uart_stdio_rx by
default) would make more sense.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/issues/11525#issuecomment-492269165
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190514/76238a37/attachment.html>


More information about the notifications mailing list