[riot-notifications] [RIOT-OS/RIOT] sam0: Implement watchdog driver (#11520)
notifications at github.com
Tue May 14 17:58:56 CEST 2019
Hi @benpicco , as @aabadie said I had also been working on a wdg implementation but for STM32. Your header definition is quite similar to mine but with the inclusion of callbacks and an extra wdt_init() function.
>From the result of discussions on previous wdg PR I had pruposed the following api:
I think we should try to merge our definitions, if we get one that works well for sam and stm platforms It should be a better more general implementation of the api.
As I see it wdg_setup(...) and wdg_configure(...) can be merged including callbacks in my header definition or using yours. Regarding wdg_init(), I think it should be discarded in favor of a single wdg_enable()/wdg_start() function since this had already been discussed in #7374 and #11252.
I propose we start a new PR for the wdg.h/wdt.h header files and implement on our side against that. What do you think?
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the notifications