[riot-notifications] [RIOT-OS/RIOT] core: fix c11 atomic definitions (fix gcc9 compilation) (#11514)

Semjon Kerner notifications at github.com
Wed May 15 12:25:55 CEST 2019


> Well, thanks for the ACK. With "it works" you mean "it compiles and basic applications still run"?

Exactly. examples/default compiles on samr21-xpro, calliope-mini (nrf51), nrf52dk and nrf52840dk. txtsnd between two nodes of nrf52840dk works as expected.

> It would be nice to take a look at the new casts and if they might have any unseen implications (e.g., reason whether casting off the pointer's volatile has any effect within an irq_disable()/irq_restore() pair, ...).

I looked at the code before acking, but still don't see a reason why volatile should break something here.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/11514#issuecomment-492598203
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190515/396d41d5/attachment.html>


More information about the notifications mailing list