[riot-notifications] [RIOT-OS/RIOT] drivers/mrf24j40: add external PA/LNA control on MC/MD/ME devices (#11410)

Carton32 notifications at github.com
Wed May 15 15:41:18 CEST 2019


I have a suggestion for your PR.

It would be great to add for each "#if MRF24J40_USE_EXT_PA_LNA" an "#else" statement like this :

`
#if MRF24J40_USE_EXT_PA_LNA  
/* code */    
#else    
    (void) dev;  
#endif  
`

otherwise you get errors at compilation for variables not used if MRF24J40_USE_EXT_PA_LNA is not set or set to 0.



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/11410#issuecomment-492659323
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190515/82d11dbd/attachment.html>


More information about the notifications mailing list