[riot-notifications] [RIOT-OS/RIOT] boards/lsn50: add support for Dragino LSN50 LoRa Sensor Node (#11524)

Francisco notifications at github.com
Fri May 17 11:21:27 CEST 2019


fjmolinas requested changes on this pull request.

Since I have v1.0 I couldn't run './dist/tools/compile_and_test_for_board/compile_and_test_for_board.py . lsn50'

I ran tests on all supplied peripherals and features as well as LoRaWAN related tests.

Ran Tests:

- tests/periph_timer
- tests/periph_rtc
- tests/periph_rtt
- tests/periph_spi
- tests/periph_uart
- tests/periph_eeprom
- tests/riotboot
- tests/xtimer_usleep
- tests/cpp11_thread
- tests/pkg_semtech-loramac

Looks good to me, some minor changes regarding documentation. I think the doxygen documentation layout could be improved following other boards styles, but I won't block this PR because of this.

> +Documentation of the board is available
+[here](https://wiki.dragino.com/index.php?title=Lora_Sensor_Node-LSN50).
+
+More documentation is available
+[here](http://wiki.dragino.com/index.php?title=Lora_Sensor_Node-LSN50#Resource).
+
+The datasheet can be downloaded
+[here](https://www.dragino.com/downloads/index.php?dir=datasheet/EN/&file=Datasheet_LoRaSensorNode.pdf).
+
+Detailed schematics are available on GitHub:
+- Board schematics are [here](https://github.com/dragino/Lora/tree/master/LSN50)
+- Radio connection schematics are [here](https://github.com/dragino/Lora/tree/master/LoRaST)
+
+### Flashing the board
+
+To flash the board, use an external ST-Link programmer/debugger. Then use

Can you reference the schematic here so a user can easily see where to connect st-link swdio/swclk/nrst pins? Just as you did for UART.

Also state that if using ST-link the board has to be supplied externally or threw JP1 in the ST-link.

Also specify that the switch must be on FLASH and not ISP

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/11524#pullrequestreview-238804171
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190517/09ac04c0/attachment-0001.html>


More information about the notifications mailing list