[riot-notifications] [RIOT-OS/RIOT] boards/lsn50: add support for Dragino LSN50 LoRa Sensor Node (#11524)
notifications at github.com
Fri May 17 11:21:27 CEST 2019
fjmolinas requested changes on this pull request.
Since I have v1.0 I couldn't run './dist/tools/compile_and_test_for_board/compile_and_test_for_board.py . lsn50'
I ran tests on all supplied peripherals and features as well as LoRaWAN related tests.
Looks good to me, some minor changes regarding documentation. I think the doxygen documentation layout could be improved following other boards styles, but I won't block this PR because of this.
> +Documentation of the board is available
+More documentation is available
+The datasheet can be downloaded
+Detailed schematics are available on GitHub:
+- Board schematics are [here](https://github.com/dragino/Lora/tree/master/LSN50)
+- Radio connection schematics are [here](https://github.com/dragino/Lora/tree/master/LoRaST)
+### Flashing the board
+To flash the board, use an external ST-Link programmer/debugger. Then use
Can you reference the schematic here so a user can easily see where to connect st-link swdio/swclk/nrst pins? Just as you did for UART.
Also state that if using ST-link the board has to be supplied externally or threw JP1 in the ST-link.
Also specify that the switch must be on FLASH and not ISP
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the notifications