[riot-notifications] [RIOT-OS/RIOT] make/pkg: allow to set SOURCE_LOCAL per pkg (#11533)

Hauke Petersen notifications at github.com
Fri May 17 11:39:01 CEST 2019


haukepetersen commented on this pull request.



> @@ -3,6 +3,7 @@
 #
 PKG_DIR?=$(CURDIR)
 PKG_BUILDDIR?=$(PKGDIRBASE)/$(PKG_NAME)
+PKG_SOURCE_LOCAL ?= $(PKG_$(shell echo $(PKG_NAME) | tr a-z A-Z)_SOURCE_LOCAL)

Hm, the command line issue is pretty unfortunate, especially as I personally prefer to use exactly the case that would not be supported anymore :-(

But keeping it consistent makes sense. Could using a `_` instead of `.` make, also in #10928, make sense maybe? In terms of parsing, it wouldn't make a difference. And also for human readability, `SOURCE_LOCAL_nimble` vs `SOURCE_LOCAL.nimble` is not the worst in the world, considering the benefits of the first option. Also `USEMODULE_INCLUDES_posix` vs `USEMODULE_INCLUDES.posix` could IMHO work, right?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/11533#discussion_r285050764
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190517/627bcc8b/attachment.html>


More information about the notifications mailing list