[riot-notifications] [RIOT-OS/RIOT] Xtimer backoff comparison (#11546)

Semjon Kerner notifications at github.com
Mon May 20 13:39:17 CEST 2019


### Contribution description

This PR adds missing type conversion/documentation of multiple `XTIMER` defines, tackling confusion between hardware ticks and microseconds.

This PR also deletes `XTIMER_MIN_SPIN`, which by my digging was never used from first definition on, yet touched a lot... rabbit hole:
https://github.com/RIOT-OS/RIOT/commit/a719e7d61ff90ce3c40a6508a5ed5af6b873cfe9#diff-2fb2297f4238db71ba10656337cfe96eR451
https://github.com/RIOT-OS/RIOT/commit/f86c118594dd15447f67e1fd0162e492e3a733d6#diff-2fb2297f4238db71ba10656337cfe96eR458
https://github.com/RIOT-OS/RIOT/commit/856c5e1539a356cb9a7f1620caa365be59e88d51#diff-2fb2297f4238db71ba10656337cfe96eR463
https://github.com/RIOT-OS/RIOT/commit/63e91151cd0b3dfde28bd7cc9b3ef23b140f3730#diff-4cf746d1ae899bdb66748fb93ac17eb0R81

If you know of more broken definitions in XTIMER, please let me so I can add them.

### Testing procedure

Do some tests/xtimer_* and make sure the values are still sane with this PR.

### Issues/PRs references

Fixes #11522 

You can view, comment on, or merge this pull request online at:

  https://github.com/RIOT-OS/RIOT/pull/11546

-- Commit Summary --

  * sys/xtimer: fix comparisons of XTIMER_BACKOFF
  * sys/xtimer: fix comparisons of XTIMER_PERIODIC_SPIN
  * sys/xtimer: delete unused XTIMER_MIN_SPIN
  * sys/xtimer: fix documentation for XTIMER_PERIODIC_RELATIVE

-- File Changes --

    M sys/include/xtimer.h (4)
    M sys/include/xtimer/implementation.h (7)
    M sys/xtimer/xtimer.c (2)
    M sys/xtimer/xtimer_core.c (4)

-- Patch Links --

https://github.com/RIOT-OS/RIOT/pull/11546.patch
https://github.com/RIOT-OS/RIOT/pull/11546.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/11546
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190520/bb442e9a/attachment.html>


More information about the notifications mailing list