[riot-notifications] [RIOT-OS/RIOT] sys/xtimer: improve spin define handling/documentation (#11546)

Francisco notifications at github.com
Mon May 20 22:23:41 CEST 2019

fjmolinas commented on this pull request.

> @@ -198,7 +198,7 @@ int _xtimer_set_absolute(xtimer_t *timer, uint32_t target)
     DEBUG("timer_set_absolute(): now=%" PRIu32 " target=%" PRIu32 " offset=%" PRIu32 "\n",
           now, target, offset);
-    if (offset <= XTIMER_BACKOFF) {
+    if (offset <= xtimer_ticks_from_usec(XTIMER_BACKOFF).ticks32) {

> XTIMER_BACKOFF is independently defined for some boards

Yes, but still constant value. Anyway it was more a question about compiler optimization but as @cladmi pointed out it should be optimized out sinze it is inline. So I'll resolve de conversation.

You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190520/48c6cf8d/attachment.html>

More information about the notifications mailing list