[riot-notifications] [RIOT-OS/RIOT] stm32 eth peripheral driver (#10633)

Alexandre Abadie notifications at github.com
Tue May 21 16:36:18 CEST 2019

Let's give an update on this one:
I tested this PR on nucleo-f767zi and was able to ping and exchange udp packets with it from my laptop which is already awesome :) Thanks @crest42, this is good job.

I tried your test applications, based on gnrc and lwip, it worked (IPv6 and v4) but I noticed some stability issues after reflashing the board. Sometimes I have trouble in getting the ethernet back in a usable state: I have to start/stop my eth interface on Linux, reboot the board to get things back to normal. Maybe there's something wrong with the initialization code or something (I haven't looked in detail) ?

To move forward fast, I allowed myself to change a few minor things:
- rebased the branch on latest master
- fixed a few rebase minor issues
- did some tiny style cleanup in the implementation eth.c file
- dropped some remaining occurrences of periph_stm32_eth
- added nucleo-f767zi in the list of boards that netif in `examples/default` Makefile

More generally, I think the test applications are not needed if the board is added to `examples/default` since there's an auto_init support so the CI will at least build the eth peripheral driver in this case.
If people wants to test higher level feature, they can try gcoap or gnrc_networking applications, it should also work (thanks to auto_init).

@kaspar030, it would be great if you could have a look at the code organisation and tell if you are happy with the current state.

You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190521/22f3f38e/attachment-0001.html>

More information about the notifications mailing list