[riot-notifications] [RIOT-OS/RIOT] drivers/mrf24j40: add external PA/LNA control on MC/MD/ME devices (#11410)

benpicco notifications at github.com
Tue May 21 16:54:04 CEST 2019


benpicco commented on this pull request.



> +#else
+    (void) dev;
+#endif
+}
+
+void mrf24j40_enable_lna(mrf24j40_t *dev)
+{
+#if MRF24J40_USE_EXT_PA_LNA
+    /* Disable automatic switch on PA/LNA */
+    mrf24j40_reg_write_long(dev, MRF24J40_REG_TESTMODE, MRF24J40_TESTMODE_RSSIWAIT0);
+
+    /* Configure all GPIOs as Output */
+    mrf24j40_reg_write_short(dev, MRF24J40_REG_TRISGPIO, 0xF);
+
+    /* Enable LNA */
+    mrf24j40_reg_write_short(dev, MRF24J40_REG_GPIO, 0xC);

GPIO3 is connected to the PA voltage regulator, so would indeed not need to be enabled here.
So I guess writing `0x4` should suffice here. I just copied that constant from the Microchip MiWi SDK driver - maybe the voltage regulator has a startup time that has to be considered, so shutting it off for short periods would be detrimental. 

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/11410#discussion_r286069555
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190521/5d62b295/attachment.html>


More information about the notifications mailing list