[riot-notifications] [RIOT-OS/RIOT] added SPI support for Nucleo-F767ZI (#11142)

Alexandre Abadie notifications at github.com
Tue May 21 17:15:21 CEST 2019


aabadie requested changes on this pull request.

I don't think the configuration for the second SPI will work on this board.

> @@ -142,6 +142,16 @@ static const spi_conf_t spi_config[] = {
         .rccmask  = RCC_APB2ENR_SPI1EN,
         .apbbus   = APB2
     },
+    {
+        .dev      = SPI2,
+        .mosi_pin = GPIO_PIN(PORT_B, 15),
+        .miso_pin = GPIO_PIN(PORT_B, 14),

I can't find PB14 on the board pinout. Is it exposed ?
By the way, I think it would more handy to provide SPI4 on PE2(SCK)/PE5(MISO)/PE6(MOSI): They are quite close and won't be under an Arduino shield plugged on this board.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/11142#pullrequestreview-240117075
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190521/b23b4d20/attachment.html>


More information about the notifications mailing list