[riot-notifications] [RIOT-OS/RIOT] gnrc_lorawan: add initial support for GNRC based LoRaWAN stack (v2) (#11022)

Sebastian Meiling notifications at github.com
Wed May 22 10:57:39 CEST 2019


smlng commented on this pull request.



> +#define GNRC_LORAWAN_REQ_STATUS_DEFERRED (1)    /**< the MLME or MCPS confirm message is asynchronous */
+
+/**
+ * @brief MAC Information Base attributes
+ */
+typedef enum {
+    MIB_ACTIVATION_METHOD
+} mlme_mib_type_t;
+
+/**
+ * @brief MAC Information Base descriptor for MLME Request-Confirm
+ */
+typedef struct {
+    mlme_mib_type_t type; /**< MIB attribute identifier */
+    union {
+        int activation;

you can stick with the union(s), but I would not name them to avoid long, complex naming when accessing the values, i.e. `foo->param.activation` could be `foo->activation` when using anonymous unions instead.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/11022#discussion_r286382515
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190522/214cc264/attachment.html>


More information about the notifications mailing list