[riot-notifications] [RIOT-OS/RIOT] RPL: API update suggestions (#11560)

Sebastian Meiling notifications at github.com
Wed May 22 13:48:22 CEST 2019

smlng requested changes on this pull request.

minor, otherwise looks good

>      void (*parent_state_callback)(gnrc_rpl_parent_t *, int, int); /**< retrieves the state of a parent*/
-    void (*init)(void);  /**< OF specific init function */
+    /**
+     * @brief Initialize the objective function.
+     *
+     * @param[in]   dodag   RPL dodag object.
+     */
+    void (*init)(gnrc_rpl_dodag_t *dodag);  /**< OF specific init function */

please remove inline comment behind, if info is required move up below `@brief` - having both is weird

You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190522/6690f230/attachment.html>

More information about the notifications mailing list