[riot-notifications] [RIOT-OS/RIOT] drivers/mrf24j40: add external PA/LNA control on MC/MD/ME devices (#11410)

benpicco notifications at github.com
Wed May 22 15:28:09 CEST 2019

benpicco commented on this pull request.

> +#else
+    (void) dev;
+void mrf24j40_enable_lna(mrf24j40_t *dev)
+    /* Disable automatic switch on PA/LNA */
+    mrf24j40_reg_write_long(dev, MRF24J40_REG_TESTMODE, MRF24J40_TESTMODE_RSSIWAIT0);
+    /* Configure all GPIOs as Output */
+    mrf24j40_reg_write_short(dev, MRF24J40_REG_TRISGPIO, 0xF);
+    /* Enable LNA */
+    mrf24j40_reg_write_short(dev, MRF24J40_REG_GPIO, 0xC);

I thought when the driver from Microchip doesn't bother with it, I could get away without doing so too 😉 

But I've added `mrf24j40_reg_and_short` / `mrf24j40_reg_or_short` now and use explicit defines for the GPIOs.

You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190522/677dc32e/attachment.html>

More information about the notifications mailing list