[riot-notifications] [RIOT-OS/RIOT] cpu/sam0: add support for SAMD5x/SAME5x (#11305)

Dylan Laduranty notifications at github.com
Thu May 23 09:28:52 CEST 2019


dylad commented on this pull request.

PM could be rework a bit.
Currently you support IDLE0, IDLE1 and IDLE2. There are present in Microchip vendor headers but datasheet states IDLE0 and IDLE1 are reserved (in SLEEPCFG register description within PM)
You also didn't add STANDBY and HIBERNATE mode, is it on purpose ?

> + * @ingroup     drivers_periph_pm
+ * @{
+ *
+ * @file
+ * @brief       Implementation of the kernels power management interface
+ *
+ * @author      Benjamin Valentin <benjamin.valentin at ml-pa.com>
+ *
+ * @}
+ */
+
+#include "periph/pm.h"
+
+#define ENABLE_DEBUG (0)
+
+#if ENABLE_DEBUG

Is it really needed ?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/11305#pullrequestreview-241028081
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190523/178cefb1/attachment.html>


More information about the notifications mailing list