[riot-notifications] [RIOT-OS/RIOT] drivers/mrf24j40 : support of NETOPT_LAST_ED_LEVEL (#10771)

benpicco notifications at github.com
Thu May 23 11:40:48 CEST 2019


benpicco commented on this pull request.



> @@ -329,6 +329,54 @@ void mrf24j40_set_cca_threshold(mrf24j40_t *dev, int8_t value)
     mrf24j40_reg_write_short(dev, MRF24J40_REG_CCAEDTH, RSSI_value[value]);
 }
 
+int8_t mrf24j40_get_ed_level(mrf24j40_t *dev)

This function basically re-implements `mrf24j40_cca()`.

Just change `bool mrf24j40_cca(mrf24j40_t *dev)` to `bool mrf24j40_cca(mrf24j40_t *dev, uint8_t *rssi, uint8_t *ccaedth)` and you'll end up with a much smaller patch and less duplicated code. 

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/10771#pullrequestreview-241093322
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190523/068c7603/attachment-0001.html>


More information about the notifications mailing list