[riot-notifications] [RIOT-OS/RIOT] boards/stm32l0: introduce common clock configuration and apply it to related boards (#11557)

Francisco notifications at github.com
Thu May 23 12:42:31 CEST 2019


fjmolinas commented on this pull request.

LGTM, just one comment and please rebase now that #11323 has been merged.

> @@ -0,0 +1,58 @@
+/*
+ * Copyright (C) 2018-2019 Inria
+ *
+ * This file is subject to the terms and conditions of the GNU Lesser
+ * General Public License v2.1. See the file LICENSE in the top level
+ * directory for more details.
+ */
+
+/**
+ * @ingroup     boards_common_stm32
+ * @{
+ *
+ * @file
+ * @brief       Configure STM32L0 clock to 32MHz with LSE

The wording here makes me think 32Mhz are achieved by using the LSE which is incorrect. Maybe reword to
`Configure STM32L0 clock to 32MHz using PLL with LSE`, what do you think?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/11557#pullrequestreview-241122029
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190523/293904ec/attachment.html>


More information about the notifications mailing list