[riot-notifications] [RIOT-OS/RIOT] sys/shell: add loramac shell command (#8855)

Francisco notifications at github.com
Thu May 23 16:53:34 CEST 2019


fjmolinas requested changes on this pull request.

@aabadie I still have a couple of un-addressed comments, also could you split the PR in two the auto_init part and the shell part. Otherwise I tested that it works.

> @@ -277,9 +277,14 @@ void auto_init(void)
 #endif
 
 #ifdef MODULE_SX127X
+#ifdef MODULE_SEMTECH_LORAMAC

I don't see why this should be in GRNC_NETIF, it has nothing to do with GNRC.

> @@ -14,6 +14,7 @@ LORA_REGION ?= EU868
 USEPKG += semtech-loramac
 USEMODULE += $(LORA_DRIVER)
 
+USEMODULE += auto_init_gnrc_netif

I don't see why this should be in GRNC_NETIF, it has nothing to do with GNRC.

> + * @{
+ *
+ * @file
+ * @brief       Auto initialization for Semtech Loramac-node package
+ *
+ * @author      Alexandre Abadie <alexandre.abadie at inria.fr>
+ */
+
+#ifdef MODULE_SEMTECH_LORAMAC
+
+#include "log.h"
+#include "semtech_loramac.h"
+
+semtech_loramac_t loramac;
+
+void auto_init_loramac(void)

This should be a different PR, auto_init for LoRaMAC and the shell.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/8855#pullrequestreview-241256234
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190523/e9becef9/attachment.html>


More information about the notifications mailing list