[riot-notifications] [RIOT-OS/RIOT] boards/native: fix overriden INCLUDES leading to build failure (#11572)
notifications at github.com
Fri May 24 13:38:32 CEST 2019
The RIOT community cares a lot about code quality.
Therefore, before describing what your contribution is about, we would like
you to make sure that your modifications are compliant with the RIOT
coding conventions, see https://github.com/RIOT-OS/RIOT/wiki/Coding-conventions.
### Contribution description
Put here the description of your contribution:
- describe which part(s) of RIOT is (are) involved
- if it's a bug fix, describe the bug that it solves and how it is solved
- you can also give more information to reviewers about how to test your changes
This PR fixes an issue when one loads the `log_printfnoformat` submodule into an application and builds for native. This use case works for all other boards.
I'm not sure this is the best fix and I'm also wondering why using `INCLUDES = $(NATIVEINCLUDES)` in `Makefile.include` is needed.
### Testing procedure
Build an application with `log_printfnoformat` on native:
USEMODULE=log_printfnoformat make -C examples/hello-world/ clean all
With this PR it works, on master, you get the following error:
make: Entering directory '/home/aabadie/softs/src/riot/RIOT/examples/hello-world'
Building application "hello-world" for "native" with MCU "native".
"make" -C /home/aabadie/softs/src/riot/RIOT/boards/native
In file included from /home/aabadie/softs/src/riot/RIOT/boards/native/board.c:21:
/home/aabadie/softs/src/riot/RIOT/core/include/log.h:98:10: fatal error: log_module.h: No such file or directory
Details steps to test your contribution:
- which test/example to compile for which board and is there a 'test' command
- how to know that it was not working/available in master
- the expected success test output
### Issues/PRs references
Examples: Fixes #1234. See also #5678. Depends on PR #9876.
Please use keywords (e.g., fixes, resolve) with the links to the issues you
resolved, this way they will be automatically closed when your pull request
is merged. See https://help.github.com/articles/closing-issues-using-keywords/.
You can view, comment on, or merge this pull request online at:
-- Commit Summary --
* boards/native: fix overriden INCLUDES leading to build failure
-- File Changes --
M boards/native/Makefile (2)
-- Patch Links --
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the notifications