[riot-notifications] [RIOT-OS/RIOT] posix_socket: initialize uninitialized fields (#11575)
notifications at github.com
Fri May 24 15:16:09 CEST 2019
The RIOT community cares a lot about code quality.
Therefore, before describing what your contribution is about, we would like
you to make sure that your modifications are compliant with the RIOT
coding conventions, see https://github.com/RIOT-OS/RIOT/wiki/Coding-conventions.
### Contribution description
Some fields of `_sock_tl_ep` were not initialized when converting a sockaddr to a `_sock_tl_ep`. Though currently the only missing field is `netif` it is safer to use `memset()` here, to make the implementation more future proof.
Put here the description of your contribution:
- describe which part(s) of RIOT is (are) involved
- if it's a bug fix, describe the bug that it solves and how it is solved
- you can also give more information to reviewers about how to test your changes
### Testing procedure
Flash and run the application provided in https://github.com/RIOT-OS/RIOT/issues/11212 on 2 `samr21-xpro`s. Without this PR, the `echo send` command will report errno 22 (`EINVAL`), with it it will report `EBADF` (or crash if https://github.com/RIOT-OS/RIOT/issues/11212#issuecomment-495617061 is not applied).
Details steps to test your contribution:
- which test/example to compile for which board and is there a 'test' command
- how to know that it was not working/available in master
- the expected success test output
### Issues/PRs references
Addresses https://github.com/RIOT-OS/RIOT/issues/11212 but does not fix it, as that issue contains multiple bugs.
Examples: Fixes #1234. See also #5678. Depends on PR #9876.
Please use keywords (e.g., fixes, resolve) with the links to the issues you
resolved, this way they will be automatically closed when your pull request
is merged. See https://help.github.com/articles/closing-issues-using-keywords/.
You can view, comment on, or merge this pull request online at:
-- Commit Summary --
* posix_socket: initialize uninitialized fields
-- File Changes --
M sys/posix/sockets/posix_sockets.c (2)
-- Patch Links --
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the notifications