[riot-notifications] [RIOT-OS/RIOT] gnrc_sixlowpan_frag: make aggresive override configurable (#11442)

Cenk Gündoğan notifications at github.com
Fri May 24 17:20:36 CEST 2019


cgundogan approved this pull request.



> @@ -322,10 +322,17 @@ static rbuf_t *_rbuf_get(const void *src, size_t src_len,
         /* if oldest is not empty, res must not be NULL (because otherwise
          * oldest could have been picked as res) */
         assert(!rbuf_entry_empty(oldest));
-        DEBUG("6lo rfrag: reassembly buffer full, remove oldest entry\n");
-        gnrc_pktbuf_release(oldest->super.pkt);
-        rbuf_rm(oldest);
-        res = oldest;
+        if (GNRC_SIXLOWPAN_FRAG_RBUF_AGGRESSIVE_OVERRIDE ||
+            ((now_usec - oldest->arrival) >
+            GNRC_SIXLOWPAN_FRAG_RBUF_TIMEOUT_MS)) {

the suffix `_MS` of `GNRC_SIXLOWPAN_FRAG_RBUF_TIMEOUT_MS` is strangely chosen for a macro that holds microseconds .. however, this is unrelated to this PR. ACK!

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/11442#pullrequestreview-241803009
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190524/f8391f8e/attachment.html>


More information about the notifications mailing list