[riot-notifications] [RIOT-OS/RIOT] minmea: bump version to current master (#11579)
notifications at github.com
Fri May 24 19:14:31 CEST 2019
The RIOT community cares a lot about code quality.
Therefore, before describing what your contribution is about, we would like
you to make sure that your modifications are compliant with the RIOT
coding conventions, see https://github.com/RIOT-OS/RIOT/wiki/Coding-conventions.
### Contribution description
While reviewing #11227, I noticed, that the problem for ATmega platforms with the `minmea` package is easily fixable. And indeed it was [fixed upstream](https://github.com/kosma/minmea/commit/4d9710940889b0b31385e6fb71b977e0f3e9944d). In addition to the fix and the removal of the blacklisting of the ATmega platforms for the test application, I also adapted the test application to use `fmt` so one also gets a sensible output with it for smaller platforms and `newlib-nano`.
Put here the description of your contribution:
- describe which part(s) of RIOT is (are) involved
- if it's a bug fix, describe the bug that it solves and how it is solved
- you can also give more information to reviewers about how to test your changes
### Testing procedure
export BOARD="<your favorite>"
make -C tests/pkg_minmea flash
make -C tests/pkg_minmea test
I tested on `samr21-xpro`, `native`, `arduino-mega2560`, and `arduino-leonardo`.
Details steps to test your contribution:
- which test/example to compile for which board and is there a 'test' command
- how to know that it was not working/available in master
- the expected success test output
### Issues/PRs references
Examples: Fixes #1234. See also #5678. Depends on PR #9876.
Please use keywords (e.g., fixes, resolve) with the links to the issues you
resolved, this way they will be automatically closed when your pull request
is merged. See https://help.github.com/articles/closing-issues-using-keywords/.
You can view, comment on, or merge this pull request online at:
-- Commit Summary --
* tests/pkg_minmea: port to fmt
* minmea: bump version to current master
* tests/pkg_minmea: remove blacklisting of ATmega-based boards
-- File Changes --
M pkg/minmea/Makefile (2)
M tests/pkg_minmea/Makefile (12)
M tests/pkg_minmea/main.c (16)
M tests/pkg_minmea/tests/01-run.py (1)
-- Patch Links --
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the notifications