[riot-notifications] [RIOT-OS/RIOT] sys/xtimer: improve spin define handling/documentation (#11546)

Francisco notifications at github.com
Sat May 25 16:52:36 CEST 2019


> Question is now, is it worth the effort to reevaluate best fitting backoff values or is this PR in vain and XTIMER_BACKOFF should be used as ticks instead, as it seems to be used as ticks in most cases?

I thin your comments in #11522 where sensible, `XTIMER_BACKOFF` as `us` is more user-friendly. Changing to us does seem like the more tedious way to got but the best in the end. Only board defining `XTIMER_HZ != `1000000` should be affected by your changes. I can provide the changes for frdm-kw41z (which I have), but I don't have any of the other boards.

For the other ones we could just manually re-calculate those values and it should work, as long as  xtimer_ticks_from_usec(XTIMER_BACKOFF).ticks32) = XTIMER_BACKOFF (before this PR) it should still work (or work just as before).

Anyways, yes its more work but I thinks its a sensible change, so +1 for this PR on my side. (I'll try to make time next week to help with testing on the board I have)



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/11546#issuecomment-495924272
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190525/934b7ab7/attachment.html>


More information about the notifications mailing list