[riot-notifications] [RIOT-OS/RIOT] gnrc_sixlowpan_frag: allow send of multiple datagrams simultaneously (#11021)

Cenk Gündoğan notifications at github.com
Mon May 27 09:47:50 CEST 2019


cgundogan approved this pull request.

The code looks good, tested on the iotlab testbed using 2 nodes. The normal operation still works. I then compiled with `GNRC_SIXLOWPAN_MSG_FRAG_SIZE=2` and reduced the ping interval in order to get interleaving ping fragments.

With below configuration pinging works:
```sh
ping6 -c 100 -i 200 -s 1232 ...
```

With below configuration pinging does not work:
```sh
ping6 -c 100 -i 100 -s 1232 ...
```

I assume that with a payload of 1232 I trigger ~10 fragments with an average RTT of ~100ms.
While a pinging interval of 200ms yields almost 100% success, pinging with 100ms yields 0% success. I can't tell whether it's just because of a too small fragmentation buffer.

Nevertheless, the proposed change is sane and the default is to handle **1** datagram at a time anyways. ACK from my side.



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/11021#pullrequestreview-242138947
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190527/008a966e/attachment.html>


More information about the notifications mailing list