[riot-notifications] [RIOT-OS/RIOT] boards/common/nrf52: add openocd support for 'nordic_softdevice_ble' (#11470)

Alexandre Abadie notifications at github.com
Mon May 27 15:49:32 CEST 2019


aabadie requested changes on this pull request.

Tested and confirmed gnrc_networking is working (shell available, ifconfig returns a configured interface) when flashing with both jlink and openocd.

The python test script also works as expected but can be improved.


> @@ -0,0 +1,38 @@
+#!/usr/bin/env python3
+
+# Copyright (C) 2019 Freie Universit├Ąt Berlin
+#
+# This file is subject to the terms and conditions of the GNU Lesser
+# General Public License v2.1. See the file LICENSE in the top level
+# directory for more details.
+
+import sys
+from testrunner import run
+

There's an extra blank line here, 2 are enough ;)

> @@ -0,0 +1,38 @@
+#!/usr/bin/env python3
+
+# Copyright (C) 2019 Freie Universit├Ąt Berlin
+#
+# This file is subject to the terms and conditions of the GNU Lesser
+# General Public License v2.1. See the file LICENSE in the top level
+# directory for more details.
+
+import sys
+from testrunner import run
+
+
+
+def _check_shell_is_working(child, tries=5):

No need for loops, just do the following:
```suggestion
def _check_shell_is_working(child):
    """Just check that the shell is working.

    It ensures the application did not crash.
    """
    child.expect_exact('All up, running the shell now')
    child.sendline('help')
    child.expect_exact('Command              Description', timeout=1)
    child.expect_exact('---------------------------------------', timeout=1)
    child.expect_exact('> ', timeout=1)
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/11470#pullrequestreview-242285869
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190527/9f04a7c4/attachment.html>


More information about the notifications mailing list