[riot-notifications] [RIOT-OS/RIOT] sys/log: add module for colorized logging (#11573)

Juan I Carrano notifications at github.com
Mon May 27 15:51:11 CEST 2019


jcarrano commented on this pull request.



> +    va_start(args, format);
+    /* Temporarily disable clang format-nonliteral warning */
+#ifdef __clang__
+#pragma clang diagnostic push
+#pragma clang diagnostic ignored "-Wformat-nonliteral"
+#endif /* clang */
+    vprintf(format, args);
+#ifdef __clang__
+#pragma clang diagnostic pop
+#endif /* clang */
+    va_end(args);
+    printf(LOG_RESET_ANSI_COLOR_CODE);
+
+#ifdef MODULE_NEWLIB
+    /* no fflush on msp430 */
+    fflush(stdout);

Given that the terminal or the riot app can terminate at any moment (and that there is no flush in MSP430), one cannot really count on the RIOT app to reset the terminal state. The robust solution is to have "make term" or pyterm handle this by resetting after exit.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/11573#discussion_r287798490
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190527/bebdc23e/attachment-0001.html>


More information about the notifications mailing list