[riot-notifications] [RIOT-OS/RIOT] makefiles/toolchain: fallback to 'objdump' (#11547)

Juan I Carrano notifications at github.com
Mon May 27 15:58:35 CEST 2019


jcarrano requested changes on this pull request.

a small oops, otherwise it is OK.

> @@ -25,7 +25,8 @@ ifeq ($(OBJCOPY),)
 $(warning objcopy not found. Hex file will not be created.)
 export OBJCOPY     = true
 endif
-export OBJDUMP     = $(LLVMPREFIX)objdump
+# Default to the native (g)objdump, helps when using toolchain from docker
+export OBJDUMP    ?= $(or $(shell command -v $(LLVMPREFIX)objdump || command -v gobjdump),objump)

```suggestion
export OBJDUMP    ?= $(or $(shell command -v $(LLVMPREFIX)objdump || command -v gobjdump),objdump)
```

> @@ -18,6 +18,7 @@ ifeq ($(OBJCOPY),)
 $(warning objcopy not found. Hex file will not be created.)
 export OBJCOPY    = true
 endif
-export OBJDUMP    = $(PREFIX)objdump
+# Default to the native (g)objdump, helps when using toolchain from docker
+export OBJDUMP   ?= $(or $(shell command -v $(PREFIX)objdump || command -v gobjdump),objump)

```suggestion
export OBJDUMP   ?= $(or $(shell command -v $(PREFIX)objdump || command -v gobjdump),objdump)
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/11547#pullrequestreview-242290219
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190527/fbbe6cc9/attachment.html>


More information about the notifications mailing list